patch.diff 27 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982
  1. From 56af7e99a819758c6bedc6d745a9f810f3fc050d Mon Sep 17 00:00:00 2001
  2. From: Gogs <gogitservice@gmail.com>
  3. Date: Wed, 19 Mar 2014 21:57:55 +0800
  4. Subject: [PATCH] fork render
  5. ---
  6. .gopmfile | 1 -
  7. modules/base/template.go | 5 +
  8. modules/middleware/auth.go | 4 +-
  9. modules/middleware/context.go | 28 ++---
  10. modules/middleware/render.go | 286 ++++++++++++++++++++++++++++++++++++++++++
  11. modules/middleware/repo.go | 6 +-
  12. routers/dashboard.go | 4 +-
  13. routers/repo/repo.go | 10 +-
  14. routers/repo/single.go | 32 ++---
  15. routers/user/setting.go | 24 ++--
  16. routers/user/user.go | 43 +++----
  17. templates/base/footer.tmpl | 4 +-
  18. web.go | 3 +-
  19. 13 files changed, 367 insertions(+), 83 deletions(-)
  20. create mode 100644 modules/middleware/render.go
  21. diff --git a/.gopmfile b/.gopmfile
  22. index 4c05ae4..9e2440f 100644
  23. --- a/.gopmfile
  24. +++ b/.gopmfile
  25. @@ -4,7 +4,6 @@ path=github.com/gogits/gogs
  26. [deps]
  27. github.com/codegangsta/cli=
  28. github.com/codegangsta/martini=
  29. -github.com/martini-contrib/render=
  30. github.com/martini-contrib/sessions=
  31. github.com/Unknwon/com=
  32. github.com/Unknwon/cae=
  33. diff --git a/modules/base/template.go b/modules/base/template.go
  34. index db79340..23d3d27 100644
  35. --- a/modules/base/template.go
  36. +++ b/modules/base/template.go
  37. @@ -6,7 +6,9 @@ package base
  38. import (
  39. "container/list"
  40. + "fmt"
  41. "html/template"
  42. + "time"
  43. )
  44. func Str2html(raw string) template.HTML {
  45. @@ -40,6 +42,9 @@ var TemplateFuncs template.FuncMap = map[string]interface{}{
  46. "AppDomain": func() string {
  47. return Domain
  48. },
  49. + "LoadTimes": func(startTime time.Time) string {
  50. + return fmt.Sprint(time.Since(startTime).Nanoseconds()/1e6) + "ms"
  51. + },
  52. "AvatarLink": AvatarLink,
  53. "str2html": Str2html,
  54. "TimeSince": TimeSince,
  55. diff --git a/modules/middleware/auth.go b/modules/middleware/auth.go
  56. index 84bbc7f..ed847dd 100644
  57. --- a/modules/middleware/auth.go
  58. +++ b/modules/middleware/auth.go
  59. @@ -13,7 +13,7 @@ func SignInRequire(redirect bool) martini.Handler {
  60. return func(ctx *Context) {
  61. if !ctx.IsSigned {
  62. if redirect {
  63. - ctx.Render.Redirect("/")
  64. + ctx.Redirect("/")
  65. }
  66. return
  67. } else if !ctx.User.IsActive {
  68. @@ -28,7 +28,7 @@ func SignInRequire(redirect bool) martini.Handler {
  69. func SignOutRequire() martini.Handler {
  70. return func(ctx *Context) {
  71. if ctx.IsSigned {
  72. - ctx.Render.Redirect("/")
  73. + ctx.Redirect("/")
  74. }
  75. }
  76. }
  77. diff --git a/modules/middleware/context.go b/modules/middleware/context.go
  78. index 7eaf665..c97c329 100644
  79. --- a/modules/middleware/context.go
  80. +++ b/modules/middleware/context.go
  81. @@ -7,26 +7,24 @@ package middleware
  82. import (
  83. "fmt"
  84. "net/http"
  85. + "time"
  86. "github.com/codegangsta/martini"
  87. - "github.com/martini-contrib/render"
  88. "github.com/martini-contrib/sessions"
  89. "github.com/gogits/gogs/models"
  90. "github.com/gogits/gogs/modules/auth"
  91. - "github.com/gogits/gogs/modules/base"
  92. "github.com/gogits/gogs/modules/log"
  93. )
  94. // Context represents context of a request.
  95. type Context struct {
  96. + *Render
  97. c martini.Context
  98. p martini.Params
  99. Req *http.Request
  100. Res http.ResponseWriter
  101. Session sessions.Session
  102. - Data base.TmplData
  103. - Render render.Render
  104. User *models.User
  105. IsSigned bool
  106. @@ -62,27 +60,25 @@ func (ctx *Context) RenderWithErr(msg, tpl string, form auth.Form) {
  107. ctx.Data["HasError"] = true
  108. ctx.Data["ErrorMsg"] = msg
  109. auth.AssignForm(form, ctx.Data)
  110. - ctx.Render.HTML(200, tpl, ctx.Data)
  111. + ctx.HTML(200, tpl, ctx.Data)
  112. }
  113. // Handle handles and logs error by given status.
  114. func (ctx *Context) Handle(status int, title string, err error) {
  115. log.Error("%s: %v", title, err)
  116. if martini.Dev == martini.Prod {
  117. - ctx.Render.HTML(500, "status/500", ctx.Data)
  118. + ctx.HTML(500, "status/500", ctx.Data)
  119. return
  120. }
  121. ctx.Data["ErrorMsg"] = err
  122. - ctx.Render.HTML(status, fmt.Sprintf("status/%d", status), ctx.Data)
  123. + ctx.HTML(status, fmt.Sprintf("status/%d", status), ctx.Data)
  124. }
  125. // InitContext initializes a classic context for a request.
  126. func InitContext() martini.Handler {
  127. return func(res http.ResponseWriter, r *http.Request, c martini.Context,
  128. - session sessions.Session, rd render.Render) {
  129. -
  130. - data := base.TmplData{}
  131. + session sessions.Session, rd *Render) {
  132. ctx := &Context{
  133. c: c,
  134. @@ -90,7 +86,6 @@ func InitContext() martini.Handler {
  135. Req: r,
  136. Res: res,
  137. Session: session,
  138. - Data: data,
  139. Render: rd,
  140. }
  141. @@ -99,16 +94,17 @@ func InitContext() martini.Handler {
  142. ctx.User = user
  143. ctx.IsSigned = user != nil
  144. - data["IsSigned"] = ctx.IsSigned
  145. + ctx.Data["IsSigned"] = ctx.IsSigned
  146. if user != nil {
  147. - data["SignedUser"] = user
  148. - data["SignedUserId"] = user.Id
  149. - data["SignedUserName"] = user.LowerName
  150. + ctx.Data["SignedUser"] = user
  151. + ctx.Data["SignedUserId"] = user.Id
  152. + ctx.Data["SignedUserName"] = user.LowerName
  153. }
  154. + ctx.Data["PageStartTime"] = time.Now()
  155. +
  156. c.Map(ctx)
  157. - c.Map(data)
  158. c.Next()
  159. }
  160. diff --git a/modules/middleware/render.go b/modules/middleware/render.go
  161. new file mode 100644
  162. index 0000000..8a54183
  163. --- /dev/null
  164. +++ b/modules/middleware/render.go
  165. @@ -0,0 +1,286 @@
  166. +// Copyright 2014 The Gogs Authors. All rights reserved.
  167. +// Use of this source code is governed by a MIT-style
  168. +// license that can be found in the LICENSE file.
  169. +
  170. +// foked from https://github.com/martini-contrib/render/blob/master/render.go
  171. +package middleware
  172. +
  173. +import (
  174. + "bytes"
  175. + "encoding/json"
  176. + "fmt"
  177. + "html/template"
  178. + "io"
  179. + "io/ioutil"
  180. + "net/http"
  181. + "os"
  182. + "path/filepath"
  183. + "time"
  184. +
  185. + "github.com/codegangsta/martini"
  186. +
  187. + "github.com/gogits/gogs/modules/base"
  188. +)
  189. +
  190. +const (
  191. + ContentType = "Content-Type"
  192. + ContentLength = "Content-Length"
  193. + ContentJSON = "application/json"
  194. + ContentHTML = "text/html"
  195. + ContentXHTML = "application/xhtml+xml"
  196. + defaultCharset = "UTF-8"
  197. +)
  198. +
  199. +var helperFuncs = template.FuncMap{
  200. + "yield": func() (string, error) {
  201. + return "", fmt.Errorf("yield called with no layout defined")
  202. + },
  203. +}
  204. +
  205. +type Delims struct {
  206. + Left string
  207. +
  208. + Right string
  209. +}
  210. +
  211. +type RenderOptions struct {
  212. + Directory string
  213. +
  214. + Layout string
  215. +
  216. + Extensions []string
  217. +
  218. + Funcs []template.FuncMap
  219. +
  220. + Delims Delims
  221. +
  222. + Charset string
  223. +
  224. + IndentJSON bool
  225. +
  226. + HTMLContentType string
  227. +}
  228. +
  229. +type HTMLOptions struct {
  230. + Layout string
  231. +}
  232. +
  233. +func Renderer(options ...RenderOptions) martini.Handler {
  234. + opt := prepareOptions(options)
  235. + cs := prepareCharset(opt.Charset)
  236. + t := compile(opt)
  237. + return func(res http.ResponseWriter, req *http.Request, c martini.Context) {
  238. + var tc *template.Template
  239. + if martini.Env == martini.Dev {
  240. +
  241. + tc = compile(opt)
  242. + } else {
  243. +
  244. + tc, _ = t.Clone()
  245. + }
  246. +
  247. + rd := &Render{res, req, tc, opt, cs, base.TmplData{}, time.Time{}}
  248. +
  249. + rd.Data["TmplLoadTimes"] = func() string {
  250. + if rd.startTime.IsZero() {
  251. + return ""
  252. + }
  253. + return fmt.Sprint(time.Since(rd.startTime).Nanoseconds()/1e6) + "ms"
  254. + }
  255. +
  256. + c.Map(rd.Data)
  257. + c.Map(rd)
  258. + }
  259. +}
  260. +
  261. +func prepareCharset(charset string) string {
  262. + if len(charset) != 0 {
  263. + return "; charset=" + charset
  264. + }
  265. +
  266. + return "; charset=" + defaultCharset
  267. +}
  268. +
  269. +func prepareOptions(options []RenderOptions) RenderOptions {
  270. + var opt RenderOptions
  271. + if len(options) > 0 {
  272. + opt = options[0]
  273. + }
  274. +
  275. + if len(opt.Directory) == 0 {
  276. + opt.Directory = "templates"
  277. + }
  278. + if len(opt.Extensions) == 0 {
  279. + opt.Extensions = []string{".tmpl"}
  280. + }
  281. + if len(opt.HTMLContentType) == 0 {
  282. + opt.HTMLContentType = ContentHTML
  283. + }
  284. +
  285. + return opt
  286. +}
  287. +
  288. +func compile(options RenderOptions) *template.Template {
  289. + dir := options.Directory
  290. + t := template.New(dir)
  291. + t.Delims(options.Delims.Left, options.Delims.Right)
  292. +
  293. + template.Must(t.Parse("Martini"))
  294. +
  295. + filepath.Walk(dir, func(path string, info os.FileInfo, err error) error {
  296. + r, err := filepath.Rel(dir, path)
  297. + if err != nil {
  298. + return err
  299. + }
  300. +
  301. + ext := filepath.Ext(r)
  302. + for _, extension := range options.Extensions {
  303. + if ext == extension {
  304. +
  305. + buf, err := ioutil.ReadFile(path)
  306. + if err != nil {
  307. + panic(err)
  308. + }
  309. +
  310. + name := (r[0 : len(r)-len(ext)])
  311. + tmpl := t.New(filepath.ToSlash(name))
  312. +
  313. + for _, funcs := range options.Funcs {
  314. + tmpl.Funcs(funcs)
  315. + }
  316. +
  317. + template.Must(tmpl.Funcs(helperFuncs).Parse(string(buf)))
  318. + break
  319. + }
  320. + }
  321. +
  322. + return nil
  323. + })
  324. +
  325. + return t
  326. +}
  327. +
  328. +type Render struct {
  329. + http.ResponseWriter
  330. + req *http.Request
  331. + t *template.Template
  332. + opt RenderOptions
  333. + compiledCharset string
  334. +
  335. + Data base.TmplData
  336. +
  337. + startTime time.Time
  338. +}
  339. +
  340. +func (r *Render) JSON(status int, v interface{}) {
  341. + var result []byte
  342. + var err error
  343. + if r.opt.IndentJSON {
  344. + result, err = json.MarshalIndent(v, "", " ")
  345. + } else {
  346. + result, err = json.Marshal(v)
  347. + }
  348. + if err != nil {
  349. + http.Error(r, err.Error(), 500)
  350. + return
  351. + }
  352. +
  353. + r.Header().Set(ContentType, ContentJSON+r.compiledCharset)
  354. + r.WriteHeader(status)
  355. + r.Write(result)
  356. +}
  357. +
  358. +func (r *Render) JSONString(v interface{}) (string, error) {
  359. + var result []byte
  360. + var err error
  361. + if r.opt.IndentJSON {
  362. + result, err = json.MarshalIndent(v, "", " ")
  363. + } else {
  364. + result, err = json.Marshal(v)
  365. + }
  366. + if err != nil {
  367. + return "", err
  368. + }
  369. + return string(result), nil
  370. +}
  371. +
  372. +func (r *Render) renderBytes(name string, binding interface{}, htmlOpt ...HTMLOptions) (*bytes.Buffer, error) {
  373. + opt := r.prepareHTMLOptions(htmlOpt)
  374. +
  375. + if len(opt.Layout) > 0 {
  376. + r.addYield(name, binding)
  377. + name = opt.Layout
  378. + }
  379. +
  380. + out, err := r.execute(name, binding)
  381. + if err != nil {
  382. + return nil, err
  383. + }
  384. +
  385. + return out, nil
  386. +}
  387. +
  388. +func (r *Render) HTML(status int, name string, binding interface{}, htmlOpt ...HTMLOptions) {
  389. + r.startTime = time.Now()
  390. +
  391. + out, err := r.renderBytes(name, binding, htmlOpt...)
  392. + if err != nil {
  393. + http.Error(r, err.Error(), http.StatusInternalServerError)
  394. + return
  395. + }
  396. +
  397. + r.Header().Set(ContentType, r.opt.HTMLContentType+r.compiledCharset)
  398. + r.WriteHeader(status)
  399. + io.Copy(r, out)
  400. +}
  401. +
  402. +func (r *Render) HTMLString(name string, binding interface{}, htmlOpt ...HTMLOptions) (string, error) {
  403. + if out, err := r.renderBytes(name, binding, htmlOpt...); err != nil {
  404. + return "", err
  405. + } else {
  406. + return out.String(), nil
  407. + }
  408. +}
  409. +
  410. +func (r *Render) Error(status int) {
  411. + r.WriteHeader(status)
  412. +}
  413. +
  414. +func (r *Render) Redirect(location string, status ...int) {
  415. + code := http.StatusFound
  416. + if len(status) == 1 {
  417. + code = status[0]
  418. + }
  419. +
  420. + http.Redirect(r, r.req, location, code)
  421. +}
  422. +
  423. +func (r *Render) Template() *template.Template {
  424. + return r.t
  425. +}
  426. +
  427. +func (r *Render) execute(name string, binding interface{}) (*bytes.Buffer, error) {
  428. + buf := new(bytes.Buffer)
  429. + return buf, r.t.ExecuteTemplate(buf, name, binding)
  430. +}
  431. +
  432. +func (r *Render) addYield(name string, binding interface{}) {
  433. + funcs := template.FuncMap{
  434. + "yield": func() (template.HTML, error) {
  435. + buf, err := r.execute(name, binding)
  436. +
  437. + return template.HTML(buf.String()), err
  438. + },
  439. + }
  440. + r.t.Funcs(funcs)
  441. +}
  442. +
  443. +func (r *Render) prepareHTMLOptions(htmlOpt []HTMLOptions) HTMLOptions {
  444. + if len(htmlOpt) > 0 {
  445. + return htmlOpt[0]
  446. + }
  447. +
  448. + return HTMLOptions{
  449. + Layout: r.opt.Layout,
  450. + }
  451. +}
  452. diff --git a/modules/middleware/repo.go b/modules/middleware/repo.go
  453. index db29bd1..a12212a 100644
  454. --- a/modules/middleware/repo.go
  455. +++ b/modules/middleware/repo.go
  456. @@ -30,7 +30,7 @@ func RepoAssignment(redirect bool) martini.Handler {
  457. user, err = models.GetUserByName(params["username"])
  458. if err != nil {
  459. if redirect {
  460. - ctx.Render.Redirect("/")
  461. + ctx.Redirect("/")
  462. return
  463. }
  464. ctx.Handle(200, "RepoAssignment", err)
  465. @@ -42,7 +42,7 @@ func RepoAssignment(redirect bool) martini.Handler {
  466. if user == nil {
  467. if redirect {
  468. - ctx.Render.Redirect("/")
  469. + ctx.Redirect("/")
  470. return
  471. }
  472. ctx.Handle(200, "RepoAssignment", errors.New("invliad user account for single repository"))
  473. @@ -55,7 +55,7 @@ func RepoAssignment(redirect bool) martini.Handler {
  474. repo, err := models.GetRepositoryByName(user, params["reponame"])
  475. if err != nil {
  476. if redirect {
  477. - ctx.Render.Redirect("/")
  478. + ctx.Redirect("/")
  479. return
  480. }
  481. ctx.Handle(200, "RepoAssignment", err)
  482. diff --git a/routers/dashboard.go b/routers/dashboard.go
  483. index d5358f0..6c194ad 100644
  484. --- a/routers/dashboard.go
  485. +++ b/routers/dashboard.go
  486. @@ -15,10 +15,10 @@ func Home(ctx *middleware.Context) {
  487. return
  488. }
  489. ctx.Data["PageIsHome"] = true
  490. - ctx.Render.HTML(200, "home", ctx.Data)
  491. + ctx.HTML(200, "home", ctx.Data)
  492. }
  493. func Help(ctx *middleware.Context) {
  494. ctx.Data["PageIsHelp"] = true
  495. - ctx.Render.HTML(200, "help", ctx.Data)
  496. + ctx.HTML(200, "help", ctx.Data)
  497. }
  498. diff --git a/routers/repo/repo.go b/routers/repo/repo.go
  499. index 61bf47c..947643a 100644
  500. --- a/routers/repo/repo.go
  501. +++ b/routers/repo/repo.go
  502. @@ -17,7 +17,7 @@ func Create(ctx *middleware.Context, form auth.CreateRepoForm) {
  503. if ctx.Req.Method == "GET" {
  504. ctx.Data["LanguageIgns"] = models.LanguageIgns
  505. ctx.Data["Licenses"] = models.Licenses
  506. - ctx.Render.HTML(200, "repo/create", ctx.Data)
  507. + ctx.HTML(200, "repo/create", ctx.Data)
  508. return
  509. }
  510. @@ -25,7 +25,7 @@ func Create(ctx *middleware.Context, form auth.CreateRepoForm) {
  511. form.Language, form.License, form.Visibility == "private", form.InitReadme == "on")
  512. if err == nil {
  513. log.Trace("%s Repository created: %s/%s", ctx.Req.RequestURI, ctx.User.LowerName, form.RepoName)
  514. - ctx.Render.Redirect("/"+ctx.User.Name+"/"+form.RepoName, 302)
  515. + ctx.Redirect("/"+ctx.User.Name+"/"+form.RepoName, 302)
  516. return
  517. } else if err == models.ErrRepoAlreadyExist {
  518. ctx.RenderWithErr("Repository name has already been used", "repo/create", &form)
  519. @@ -36,7 +36,7 @@ func Create(ctx *middleware.Context, form auth.CreateRepoForm) {
  520. func SettingPost(ctx *middleware.Context) {
  521. if !ctx.Repo.IsOwner {
  522. - ctx.Render.Error(404)
  523. + ctx.Error(404)
  524. return
  525. }
  526. @@ -44,7 +44,7 @@ func SettingPost(ctx *middleware.Context) {
  527. case "delete":
  528. if len(ctx.Repo.Repository.Name) == 0 || ctx.Repo.Repository.Name != ctx.Query("repository") {
  529. ctx.Data["ErrorMsg"] = "Please make sure you entered repository name is correct."
  530. - ctx.Render.HTML(200, "repo/setting", ctx.Data)
  531. + ctx.HTML(200, "repo/setting", ctx.Data)
  532. return
  533. }
  534. @@ -55,5 +55,5 @@ func SettingPost(ctx *middleware.Context) {
  535. }
  536. log.Trace("%s Repository deleted: %s/%s", ctx.Req.RequestURI, ctx.User.LowerName, ctx.Repo.Repository.LowerName)
  537. - ctx.Render.Redirect("/", 302)
  538. + ctx.Redirect("/", 302)
  539. }
  540. diff --git a/routers/repo/single.go b/routers/repo/single.go
  541. index d64248d..171b095 100644
  542. --- a/routers/repo/single.go
  543. +++ b/routers/repo/single.go
  544. @@ -27,7 +27,7 @@ func Branches(ctx *middleware.Context, params martini.Params) {
  545. ctx.Handle(200, "repo.Branches", err)
  546. return
  547. } else if len(brs) == 0 {
  548. - ctx.Render.Error(404)
  549. + ctx.Error(404)
  550. return
  551. }
  552. @@ -38,7 +38,7 @@ func Branches(ctx *middleware.Context, params martini.Params) {
  553. ctx.Data["Branches"] = brs
  554. ctx.Data["IsRepoToolbarBranches"] = true
  555. - ctx.Render.HTML(200, "repo/branches", ctx.Data)
  556. + ctx.HTML(200, "repo/branches", ctx.Data)
  557. }
  558. func Single(ctx *middleware.Context, params martini.Params) {
  559. @@ -57,11 +57,11 @@ func Single(ctx *middleware.Context, params martini.Params) {
  560. brs, err := models.GetBranches(params["username"], params["reponame"])
  561. if err != nil {
  562. log.Error("repo.Single(GetBranches): %v", err)
  563. - ctx.Render.Error(404)
  564. + ctx.Error(404)
  565. return
  566. } else if len(brs) == 0 {
  567. ctx.Data["IsBareRepo"] = true
  568. - ctx.Render.HTML(200, "repo/single", ctx.Data)
  569. + ctx.HTML(200, "repo/single", ctx.Data)
  570. return
  571. }
  572. @@ -72,7 +72,7 @@ func Single(ctx *middleware.Context, params martini.Params) {
  573. params["branchname"], params["commitid"], treename)
  574. if err != nil {
  575. log.Error("repo.Single(GetReposFiles): %v", err)
  576. - ctx.Render.Error(404)
  577. + ctx.Error(404)
  578. return
  579. }
  580. ctx.Data["Username"] = params["username"]
  581. @@ -94,7 +94,7 @@ func Single(ctx *middleware.Context, params martini.Params) {
  582. params["branchname"], params["commitid"])
  583. if err != nil {
  584. log.Error("repo.Single(GetCommit): %v", err)
  585. - ctx.Render.Error(404)
  586. + ctx.Error(404)
  587. return
  588. }
  589. ctx.Data["LastCommit"] = commit
  590. @@ -130,12 +130,12 @@ func Single(ctx *middleware.Context, params martini.Params) {
  591. ctx.Data["Treenames"] = treenames
  592. ctx.Data["IsRepoToolbarSource"] = true
  593. ctx.Data["Files"] = files
  594. - ctx.Render.HTML(200, "repo/single", ctx.Data)
  595. + ctx.HTML(200, "repo/single", ctx.Data)
  596. }
  597. func Setting(ctx *middleware.Context, params martini.Params) {
  598. if !ctx.Repo.IsOwner {
  599. - ctx.Render.Error(404)
  600. + ctx.Error(404)
  601. return
  602. }
  603. @@ -143,11 +143,11 @@ func Setting(ctx *middleware.Context, params martini.Params) {
  604. brs, err := models.GetBranches(params["username"], params["reponame"])
  605. if err != nil {
  606. log.Error("repo.Setting(GetBranches): %v", err)
  607. - ctx.Render.Error(404)
  608. + ctx.Error(404)
  609. return
  610. } else if len(brs) == 0 {
  611. ctx.Data["IsBareRepo"] = true
  612. - ctx.Render.HTML(200, "repo/setting", ctx.Data)
  613. + ctx.HTML(200, "repo/setting", ctx.Data)
  614. return
  615. }
  616. @@ -158,7 +158,7 @@ func Setting(ctx *middleware.Context, params martini.Params) {
  617. ctx.Data["Title"] = title + " - settings"
  618. ctx.Data["IsRepoToolbarSetting"] = true
  619. - ctx.Render.HTML(200, "repo/setting", ctx.Data)
  620. + ctx.HTML(200, "repo/setting", ctx.Data)
  621. }
  622. func Commits(ctx *middleware.Context, params martini.Params) {
  623. @@ -167,7 +167,7 @@ func Commits(ctx *middleware.Context, params martini.Params) {
  624. ctx.Handle(200, "repo.Commits", err)
  625. return
  626. } else if len(brs) == 0 {
  627. - ctx.Render.Error(404)
  628. + ctx.Error(404)
  629. return
  630. }
  631. @@ -175,19 +175,19 @@ func Commits(ctx *middleware.Context, params martini.Params) {
  632. commits, err := models.GetCommits(params["username"],
  633. params["reponame"], params["branchname"])
  634. if err != nil {
  635. - ctx.Render.Error(404)
  636. + ctx.Error(404)
  637. return
  638. }
  639. ctx.Data["Commits"] = commits
  640. - ctx.Render.HTML(200, "repo/commits", ctx.Data)
  641. + ctx.HTML(200, "repo/commits", ctx.Data)
  642. }
  643. func Issues(ctx *middleware.Context) {
  644. ctx.Data["IsRepoToolbarIssues"] = true
  645. - ctx.Render.HTML(200, "repo/issues", ctx.Data)
  646. + ctx.HTML(200, "repo/issues", ctx.Data)
  647. }
  648. func Pulls(ctx *middleware.Context) {
  649. ctx.Data["IsRepoToolbarPulls"] = true
  650. - ctx.Render.HTML(200, "repo/pulls", ctx.Data)
  651. + ctx.HTML(200, "repo/pulls", ctx.Data)
  652. }
  653. diff --git a/routers/user/setting.go b/routers/user/setting.go
  654. index 66289b6..719e0c1 100644
  655. --- a/routers/user/setting.go
  656. +++ b/routers/user/setting.go
  657. @@ -24,13 +24,13 @@ func Setting(ctx *middleware.Context, form auth.UpdateProfileForm) {
  658. ctx.Data["Owner"] = user
  659. if ctx.Req.Method == "GET" {
  660. - ctx.Render.HTML(200, "user/setting", ctx.Data)
  661. + ctx.HTML(200, "user/setting", ctx.Data)
  662. return
  663. }
  664. // below is for POST requests
  665. if hasErr, ok := ctx.Data["HasError"]; ok && hasErr.(bool) {
  666. - ctx.Render.HTML(200, "user/setting", ctx.Data)
  667. + ctx.HTML(200, "user/setting", ctx.Data)
  668. return
  669. }
  670. @@ -45,7 +45,7 @@ func Setting(ctx *middleware.Context, form auth.UpdateProfileForm) {
  671. }
  672. ctx.Data["IsSuccess"] = true
  673. - ctx.Render.HTML(200, "user/setting", ctx.Data)
  674. + ctx.HTML(200, "user/setting", ctx.Data)
  675. log.Trace("%s User setting updated: %s", ctx.Req.RequestURI, ctx.User.LowerName)
  676. }
  677. @@ -55,7 +55,7 @@ func SettingPassword(ctx *middleware.Context, form auth.UpdatePasswdForm) {
  678. ctx.Data["IsUserPageSettingPasswd"] = true
  679. if ctx.Req.Method == "GET" {
  680. - ctx.Render.HTML(200, "user/password", ctx.Data)
  681. + ctx.HTML(200, "user/password", ctx.Data)
  682. return
  683. }
  684. @@ -82,7 +82,7 @@ func SettingPassword(ctx *middleware.Context, form auth.UpdatePasswdForm) {
  685. }
  686. ctx.Data["Owner"] = user
  687. - ctx.Render.HTML(200, "user/password", ctx.Data)
  688. + ctx.HTML(200, "user/password", ctx.Data)
  689. log.Trace("%s User password updated: %s", ctx.Req.RequestURI, ctx.User.LowerName)
  690. }
  691. @@ -95,7 +95,7 @@ func SettingSSHKeys(ctx *middleware.Context, form auth.AddSSHKeyForm) {
  692. if err != nil {
  693. ctx.Data["ErrorMsg"] = err
  694. log.Error("ssh.DelPublicKey: %v", err)
  695. - ctx.Render.JSON(200, map[string]interface{}{
  696. + ctx.JSON(200, map[string]interface{}{
  697. "ok": false,
  698. "err": err.Error(),
  699. })
  700. @@ -109,13 +109,13 @@ func SettingSSHKeys(ctx *middleware.Context, form auth.AddSSHKeyForm) {
  701. if err = models.DeletePublicKey(k); err != nil {
  702. ctx.Data["ErrorMsg"] = err
  703. log.Error("ssh.DelPublicKey: %v", err)
  704. - ctx.Render.JSON(200, map[string]interface{}{
  705. + ctx.JSON(200, map[string]interface{}{
  706. "ok": false,
  707. "err": err.Error(),
  708. })
  709. } else {
  710. log.Trace("%s User SSH key deleted: %s", ctx.Req.RequestURI, ctx.User.LowerName)
  711. - ctx.Render.JSON(200, map[string]interface{}{
  712. + ctx.JSON(200, map[string]interface{}{
  713. "ok": true,
  714. })
  715. }
  716. @@ -125,7 +125,7 @@ func SettingSSHKeys(ctx *middleware.Context, form auth.AddSSHKeyForm) {
  717. // Add new SSH key.
  718. if ctx.Req.Method == "POST" {
  719. if hasErr, ok := ctx.Data["HasError"]; ok && hasErr.(bool) {
  720. - ctx.Render.HTML(200, "user/publickey", ctx.Data)
  721. + ctx.HTML(200, "user/publickey", ctx.Data)
  722. return
  723. }
  724. @@ -157,7 +157,7 @@ func SettingSSHKeys(ctx *middleware.Context, form auth.AddSSHKeyForm) {
  725. ctx.Data["PageIsUserSetting"] = true
  726. ctx.Data["IsUserPageSettingSSH"] = true
  727. ctx.Data["Keys"] = keys
  728. - ctx.Render.HTML(200, "user/publickey", ctx.Data)
  729. + ctx.HTML(200, "user/publickey", ctx.Data)
  730. }
  731. func SettingNotification(ctx *middleware.Context) {
  732. @@ -165,7 +165,7 @@ func SettingNotification(ctx *middleware.Context) {
  733. ctx.Data["Title"] = "Notification"
  734. ctx.Data["PageIsUserSetting"] = true
  735. ctx.Data["IsUserPageSettingNotify"] = true
  736. - ctx.Render.HTML(200, "user/notification", ctx.Data)
  737. + ctx.HTML(200, "user/notification", ctx.Data)
  738. }
  739. func SettingSecurity(ctx *middleware.Context) {
  740. @@ -173,5 +173,5 @@ func SettingSecurity(ctx *middleware.Context) {
  741. ctx.Data["Title"] = "Security"
  742. ctx.Data["PageIsUserSetting"] = true
  743. ctx.Data["IsUserPageSettingSecurity"] = true
  744. - ctx.Render.HTML(200, "user/security", ctx.Data)
  745. + ctx.HTML(200, "user/security", ctx.Data)
  746. }
  747. diff --git a/routers/user/user.go b/routers/user/user.go
  748. index d702f2b..4203007 100644
  749. --- a/routers/user/user.go
  750. +++ b/routers/user/user.go
  751. @@ -9,8 +9,6 @@ import (
  752. "strings"
  753. "github.com/codegangsta/martini"
  754. - "github.com/martini-contrib/render"
  755. - "github.com/martini-contrib/sessions"
  756. "github.com/gogits/gogs/models"
  757. "github.com/gogits/gogs/modules/auth"
  758. @@ -35,7 +33,7 @@ func Dashboard(ctx *middleware.Context) {
  759. return
  760. }
  761. ctx.Data["Feeds"] = feeds
  762. - ctx.Render.HTML(200, "user/dashboard", ctx.Data)
  763. + ctx.HTML(200, "user/dashboard", ctx.Data)
  764. }
  765. func Profile(ctx *middleware.Context, params martini.Params) {
  766. @@ -70,19 +68,19 @@ func Profile(ctx *middleware.Context, params martini.Params) {
  767. ctx.Data["Repos"] = repos
  768. }
  769. - ctx.Render.HTML(200, "user/profile", ctx.Data)
  770. + ctx.HTML(200, "user/profile", ctx.Data)
  771. }
  772. func SignIn(ctx *middleware.Context, form auth.LogInForm) {
  773. ctx.Data["Title"] = "Log In"
  774. if ctx.Req.Method == "GET" {
  775. - ctx.Render.HTML(200, "user/signin", ctx.Data)
  776. + ctx.HTML(200, "user/signin", ctx.Data)
  777. return
  778. }
  779. if hasErr, ok := ctx.Data["HasError"]; ok && hasErr.(bool) {
  780. - ctx.Render.HTML(200, "user/signin", ctx.Data)
  781. + ctx.HTML(200, "user/signin", ctx.Data)
  782. return
  783. }
  784. @@ -99,14 +97,13 @@ func SignIn(ctx *middleware.Context, form auth.LogInForm) {
  785. ctx.Session.Set("userId", user.Id)
  786. ctx.Session.Set("userName", user.Name)
  787. -
  788. - ctx.Render.Redirect("/")
  789. + ctx.Redirect("/")
  790. }
  791. -func SignOut(r render.Render, session sessions.Session) {
  792. - session.Delete("userId")
  793. - session.Delete("userName")
  794. - r.Redirect("/")
  795. +func SignOut(ctx *middleware.Context) {
  796. + ctx.Session.Delete("userId")
  797. + ctx.Session.Delete("userName")
  798. + ctx.Redirect("/")
  799. }
  800. func SignUp(ctx *middleware.Context, form auth.RegisterForm) {
  801. @@ -114,7 +111,7 @@ func SignUp(ctx *middleware.Context, form auth.RegisterForm) {
  802. ctx.Data["PageIsSignUp"] = true
  803. if ctx.Req.Method == "GET" {
  804. - ctx.Render.HTML(200, "user/signup", ctx.Data)
  805. + ctx.HTML(200, "user/signup", ctx.Data)
  806. return
  807. }
  808. @@ -127,7 +124,7 @@ func SignUp(ctx *middleware.Context, form auth.RegisterForm) {
  809. }
  810. if ctx.HasError() {
  811. - ctx.Render.HTML(200, "user/signup", ctx.Data)
  812. + ctx.HTML(200, "user/signup", ctx.Data)
  813. return
  814. }
  815. @@ -157,7 +154,7 @@ func SignUp(ctx *middleware.Context, form auth.RegisterForm) {
  816. if base.Service.RegisterEmailConfirm {
  817. auth.SendRegisterMail(u)
  818. }
  819. - ctx.Render.Redirect("/user/login")
  820. + ctx.Redirect("/user/login")
  821. }
  822. func Delete(ctx *middleware.Context) {
  823. @@ -166,7 +163,7 @@ func Delete(ctx *middleware.Context) {
  824. ctx.Data["IsUserPageSettingDelete"] = true
  825. if ctx.Req.Method == "GET" {
  826. - ctx.Render.HTML(200, "user/delete", ctx.Data)
  827. + ctx.HTML(200, "user/delete", ctx.Data)
  828. return
  829. }
  830. @@ -186,12 +183,12 @@ func Delete(ctx *middleware.Context) {
  831. return
  832. }
  833. } else {
  834. - ctx.Render.Redirect("/")
  835. + ctx.Redirect("/")
  836. return
  837. }
  838. }
  839. - ctx.Render.HTML(200, "user/delete", ctx.Data)
  840. + ctx.HTML(200, "user/delete", ctx.Data)
  841. }
  842. const (
  843. @@ -202,7 +199,7 @@ const (
  844. func Feeds(ctx *middleware.Context, form auth.FeedsForm) {
  845. actions, err := models.GetFeeds(form.UserId, form.Page*20, false)
  846. if err != nil {
  847. - ctx.Render.JSON(500, err)
  848. + ctx.JSON(500, err)
  849. }
  850. feeds := make([]string, len(actions))
  851. @@ -210,19 +207,19 @@ func Feeds(ctx *middleware.Context, form auth.FeedsForm) {
  852. feeds[i] = fmt.Sprintf(TPL_FEED, base.ActionIcon(actions[i].OpType),
  853. base.TimeSince(actions[i].Created), base.ActionDesc(actions[i], ctx.User.AvatarLink()))
  854. }
  855. - ctx.Render.JSON(200, &feeds)
  856. + ctx.JSON(200, &feeds)
  857. }
  858. func Issues(ctx *middleware.Context) {
  859. - ctx.Render.HTML(200, "user/issues", ctx.Data)
  860. + ctx.HTML(200, "user/issues", ctx.Data)
  861. }
  862. func Pulls(ctx *middleware.Context) {
  863. - ctx.Render.HTML(200, "user/pulls", ctx.Data)
  864. + ctx.HTML(200, "user/pulls", ctx.Data)
  865. }
  866. func Stars(ctx *middleware.Context) {
  867. - ctx.Render.HTML(200, "user/stars", ctx.Data)
  868. + ctx.HTML(200, "user/stars", ctx.Data)
  869. }
  870. func Activate(ctx *middleware.Context) {
  871. diff --git a/templates/base/footer.tmpl b/templates/base/footer.tmpl
  872. index 841af68..fe0ea93 100644
  873. --- a/templates/base/footer.tmpl
  874. +++ b/templates/base/footer.tmpl
  875. @@ -3,7 +3,9 @@
  876. <footer id="footer">
  877. <div class="container footer-wrap">
  878. <p>© 2014 Gogs · ver {{AppVer}} ·
  879. - <i class="fa fa-github"></i><a target="_blank" href="https://github.com/gogits/gogs">GitHub</a>
  880. + All: {{LoadTimes .PageStartTime}} ·
  881. + Tmpl: {{call .TmplLoadTimes}} ·
  882. + <i class="fa fa-github"></i><a target="_blank" href="https://github.com/gogits/gogs">GitHub</a> ·
  883. </p>
  884. <p class="desc"></p>
  885. </div>
  886. diff --git a/web.go b/web.go
  887. index e519fe1..fe3596e 100644
  888. --- a/web.go
  889. +++ b/web.go
  890. @@ -12,7 +12,6 @@ import (
  891. "github.com/codegangsta/cli"
  892. "github.com/codegangsta/martini"
  893. - "github.com/martini-contrib/render"
  894. "github.com/martini-contrib/sessions"
  895. "github.com/gogits/binding"
  896. @@ -64,7 +63,7 @@ func runWeb(*cli.Context) {
  897. m := newMartini()
  898. // Middlewares.
  899. - m.Use(render.Renderer(render.Options{Funcs: []template.FuncMap{base.TemplateFuncs}}))
  900. + m.Use(middleware.Renderer(middleware.RenderOptions{Funcs: []template.FuncMap{base.TemplateFuncs}}))
  901. // TODO: should use other store because cookie store is not secure.
  902. store := sessions.NewCookieStore([]byte("secret123"))
  903. --
  904. 1.8.4.1